salfter/fluxengine
1
0
Fork 0
mirror of https://github.com/davidgiven/fluxengine.git synced 2025-10-31 11:17:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Better support for repeated fields in the config language. Add a helper

Browse Source 
for showing all config fields in a proto.
This commit is contained in:
David Given
2025-08-10 22:22:58 +01:00
parent 8f233f55e9
commit df4d27eefe
11 changed files with 290 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

86
lib/config/common.proto
View File

@@ -2,54 +2,58 @@ syntax = "proto2";
import "google/protobuf/descriptor.proto"; import "google/protobuf/descriptor.proto";
message RangeProto { extend google.protobuf.FieldOptions
optional int32 start = 1 [default = 0, (help) = "start value"]; {
optional int32 step = 2 [default = 1, (help) = "amount to step by (positive)"]; optional string help = 50000;
optional int32 end = 3 [(help) = "inclusive end value, defaulting to the start value"];
} }
extend google.protobuf.FieldOptions { extend google.protobuf.MessageOptions
optional string help = 50000; {
optional bool recurse = 50001 [default = true]; optional bool recurse = 50001 [default = true];
} }
enum IndexMode { message RangeProto
INDEXMODE_DRIVE = 0; {
INDEXMODE_300 = 1; option(recurse) = false;
INDEXMODE_360 = 2;
optional int32 start = 1 [default = 0, (help) = "start value"];
optional int32 step =
2 [default = 1, (help) = "amount to step by (positive)"];
optional int32 end =
3 [(help) = "inclusive end value, defaulting to the start value"];
} }
enum FluxSourceSinkType { enum IndexMode
FLUXTYPE_NOT_SET = 0; {
FLUXTYPE_A2R = 1; INDEXMODE_DRIVE = 0; INDEXMODE_300 = 1; INDEXMODE_360 = 2;
FLUXTYPE_AU = 2;
FLUXTYPE_CWF = 3;
FLUXTYPE_DRIVE = 4;
FLUXTYPE_ERASE = 5;
FLUXTYPE_FLUX = 6;
FLUXTYPE_FLX = 7;
FLUXTYPE_KRYOFLUX = 8;
FLUXTYPE_SCP = 9;
FLUXTYPE_TEST_PATTERN = 10;
FLUXTYPE_VCD = 11;
FLUXTYPE_DMK = 12;
} }
enum ImageReaderWriterType { enum FluxSourceSinkType
IMAGETYPE_NOT_SET = 0; {
IMAGETYPE_D64 = 1; FLUXTYPE_NOT_SET = 0; FLUXTYPE_A2R = 1; FLUXTYPE_AU = 2; FLUXTYPE_CWF = 3;
IMAGETYPE_D88 = 2; FLUXTYPE_DRIVE = 4;
IMAGETYPE_DIM = 3; FLUXTYPE_ERASE = 5;
IMAGETYPE_DISKCOPY = 4; FLUXTYPE_FLUX = 6;
IMAGETYPE_FDI = 5; FLUXTYPE_FLX = 7;
IMAGETYPE_IMD = 6; FLUXTYPE_KRYOFLUX = 8;
IMAGETYPE_IMG = 7; FLUXTYPE_SCP = 9;
IMAGETYPE_JV3 = 8; FLUXTYPE_TEST_PATTERN = 10;
IMAGETYPE_LDBS = 9; FLUXTYPE_VCD = 11;
IMAGETYPE_NFD = 10; FLUXTYPE_DMK = 12;
IMAGETYPE_NSI = 11;
IMAGETYPE_RAW = 12;
IMAGETYPE_TD0 = 13;
} }
enum ImageReaderWriterType
{
IMAGETYPE_NOT_SET = 0; IMAGETYPE_D64 = 1; IMAGETYPE_D88 = 2;
IMAGETYPE_DIM = 3;
IMAGETYPE_DISKCOPY = 4;
IMAGETYPE_FDI = 5;
IMAGETYPE_IMD = 6;
IMAGETYPE_IMG = 7;
IMAGETYPE_JV3 = 8;
IMAGETYPE_LDBS = 9;
IMAGETYPE_NFD = 10;
IMAGETYPE_NSI = 11;
IMAGETYPE_RAW = 12;
IMAGETYPE_TD0 = 13;
}

35
lib/config/config.proto
View File

@@ -14,20 +14,20 @@ import "lib/config/layout.proto";
enum SupportStatus enum SupportStatus
{ {
UNSUPPORTED = 0; UNSUPPORTED = 0; DINOSAUR = 1; UNICORN = 2;
DINOSAUR = 1;
UNICORN = 2;
} }
// NEXT_TAG: 27 // NEXT_TAG: 27
message ConfigProto message ConfigProto
{ {
option(recurse) = false;
optional string shortname = 1; optional string shortname = 1;
optional string comment = 2; optional string comment = 2;
optional bool is_extension = 3; optional bool is_extension = 3;
repeated string documentation = 4; repeated string documentation = 4;
optional SupportStatus read_support_status = 5 [ default = UNSUPPORTED ]; optional SupportStatus read_support_status = 5 [default = UNSUPPORTED];
optional SupportStatus write_support_status = 6 [ default = UNSUPPORTED ]; optional SupportStatus write_support_status = 6 [default = UNSUPPORTED];
optional LayoutProto layout = 7; optional LayoutProto layout = 7;
@@ -52,28 +52,27 @@ message ConfigProto
message OptionPrerequisiteProto message OptionPrerequisiteProto
{ {
optional string key = 1 [ (help) = "path to config value" ]; optional string key = 1 [(help) = "path to config value"];
repeated string value = 2 [ (help) = "list of required values" ]; repeated string value = 2 [(help) = "list of required values"];
} }
// NEXT_TAG: 8 // NEXT_TAG: 8
message OptionProto message OptionProto
{ {
optional string name = 1 [ (help) = "option name" ]; optional string name = 1 [(help) = "option name"];
optional string comment = 2 [ (help) = "help text for option" ]; optional string comment = 2 [(help) = "help text for option"];
optional string message = 3 optional string message =
[ (help) = "message to display when option is in use" ]; 3 [(help) = "message to display when option is in use"];
optional bool set_by_default = 6 optional bool set_by_default =
[ (help) = "this option is applied by default", default = false ]; 6 [(help) = "this option is applied by default", default = false];
repeated OptionPrerequisiteProto prerequisite = 7 repeated OptionPrerequisiteProto prerequisite =
[ (help) = "prerequisites for this option" ]; 7 [(help) = "prerequisites for this option"];
optional ConfigProto config = 4 optional ConfigProto config = 4 [(help) = "option data"];
[ (help) = "option data", (recurse) = false ];
} }
message OptionGroupProto message OptionGroupProto
{ {
optional string comment = 1 [ (help) = "help text for option group" ]; optional string comment = 1 [(help) = "help text for option group"];
repeated OptionProto option = 2; repeated OptionProto option = 2;
} }

2
lib/config/flags.cc
View File

@@ -264,7 +264,7 @@ static void doShowConfig()
static void doDoc() static void doDoc()
{ {
const auto fields = findAllProtoFields(globalConfig().base()); const auto fields = findAllPossibleProtoFields(globalConfig().base()->GetDescriptor());
for (const auto field : fields) for (const auto field : fields)
{ {
const std::string& path = field.first; const std::string& path = field.first;

100
lib/config/proto.cc
View File

@@ -107,6 +107,16 @@ static ProtoField resolveProtoPath(
std::stringstream ss(leading); std::stringstream ss(leading);
while (std::getline(ss, item, '.')) while (std::getline(ss, item, '.'))
{ {
static const std::regex INDEX_REGEX("(\\w+)\\[([0-9]+)\\]");
int index = -1;
std::smatch dmatch;
if (std::regex_match(item, dmatch, INDEX_REGEX))
{
item = dmatch[1];
index = std::stoi(dmatch[2]);
}
const auto* field = descriptor->FindFieldByName(item); const auto* field = descriptor->FindFieldByName(item);
if (!field) if (!field)
throw ProtoPathNotFoundException( throw ProtoPathNotFoundException(
@@ -116,6 +126,14 @@ static ProtoField resolveProtoPath(
"config field '{}' in '{}' is not a message", item, path)); "config field '{}' in '{}' is not a message", item, path));
const auto* reflection = message->GetReflection(); const auto* reflection = message->GetReflection();
if ((field->label() !=
google::protobuf::FieldDescriptor::LABEL_REPEATED) &&
(index != -1))
throw ProtoPathNotFoundException(fmt::format(
"config field '{}[{}]' is indexed, but not repeated",
item,
index));
switch (field->label()) switch (field->label())
{ {
case google::protobuf::FieldDescriptor::LABEL_OPTIONAL: case google::protobuf::FieldDescriptor::LABEL_OPTIONAL:
@@ -127,16 +145,15 @@ static ProtoField resolveProtoPath(
break; break;
case google::protobuf::FieldDescriptor::LABEL_REPEATED: case google::protobuf::FieldDescriptor::LABEL_REPEATED:
if (reflection->FieldSize(*message, field) == 0) if (index == -1)
{ throw ProtoPathNotFoundException(fmt::format(
if (create) "config field '{}' is repeated and must be indexed",
message = reflection->AddMessage(message, field); item));
else while (reflection->FieldSize(*message, field) <= index)
fail(); reflection->AddMessage(message, field);
}
else message =
message = reflection->MutableRepeatedMessage(message, field, index);
reflection->MutableRepeatedMessage(message, field, 0);
break; break;
default: default:
@@ -343,11 +360,17 @@ std::set<unsigned> iterate(unsigned start, unsigned count)
return set; return set;
} }
static bool shouldRecurse(const google::protobuf::FieldDescriptor* f)
{
if (f->type() != google::protobuf::FieldDescriptor::TYPE_MESSAGE)
return false;
return f->message_type()->options().GetExtension(::recurse);
}
std::map<std::string, const google::protobuf::FieldDescriptor*> std::map<std::string, const google::protobuf::FieldDescriptor*>
findAllProtoFields(google::protobuf::Message* message) findAllPossibleProtoFields(const google::protobuf::Descriptor* descriptor)
{ {
std::map<std::string, const google::protobuf::FieldDescriptor*> fields; std::map<std::string, const google::protobuf::FieldDescriptor*> fields;
const auto* descriptor = message->GetDescriptor();
std::function<void(const google::protobuf::Descriptor*, const std::string&)> std::function<void(const google::protobuf::Descriptor*, const std::string&)>
recurse = [&](auto* d, const auto& s) recurse = [&](auto* d, const auto& s)
@@ -357,8 +380,10 @@ findAllProtoFields(google::protobuf::Message* message)
const google::protobuf::FieldDescriptor* f = d->field(i); const google::protobuf::FieldDescriptor* f = d->field(i);
std::string n = s + f->name(); std::string n = s + f->name();
if (f->options().GetExtension(::recurse) && if (f->label() == google::protobuf::FieldDescriptor::LABEL_REPEATED)
(f->type() == google::protobuf::FieldDescriptor::TYPE_MESSAGE)) n += "[]";
if (shouldRecurse(f))
recurse(f->message_type(), n + "."); recurse(f->message_type(), n + ".");
fields[n] = f; fields[n] = f;
@@ -369,10 +394,47 @@ findAllProtoFields(google::protobuf::Message* message)
return fields; return fields;
} }
ConfigProto parseConfigBytes(const std::string_view& data) std::map<std::string, const google::protobuf::FieldDescriptor*>
findAllProtoFields(const google::protobuf::Message& message)
{ {
ConfigProto proto; std::map<std::string, const google::protobuf::FieldDescriptor*> allFields;
if (!proto.ParseFromArray(data.begin(), data.size()))
error("invalid internal config data"); std::function<void(const google::protobuf::Message&, const std::string&)>
return proto; recurse = [&](auto& message, const auto& name)
{
const auto* reflection = message.GetReflection();
std::vector<const google::protobuf::FieldDescriptor*> fields;
reflection->ListFields(message, &fields);
for (const auto* f : fields)
{
auto basename = name;
if (!basename.empty())
basename += '.';
basename += f->name();
if (f->label() == google::protobuf::FieldDescriptor::LABEL_REPEATED)
{
for (int i = 0; i < reflection->FieldSize(message, f); i++)
{
const auto n = fmt::format("{}[{}]", basename, i);
if (shouldRecurse(f))
recurse(
reflection->GetRepeatedMessage(message, f, i), n);
else
allFields[n] = f;
}
}
else
{
if (shouldRecurse(f))
recurse(reflection->GetMessage(message, f), basename);
else
allFields[basename] = f;
}
}
};
recurse(message, "");
return allFields;
} }

14
lib/config/proto.h
View File

@@ -37,9 +37,19 @@ extern std::set<unsigned> iterate(const RangeProto& range);
extern std::set<unsigned> iterate(unsigned start, unsigned count); extern std::set<unsigned> iterate(unsigned start, unsigned count);
extern std::map<std::string, const google::protobuf::FieldDescriptor*> extern std::map<std::string, const google::protobuf::FieldDescriptor*>
findAllProtoFields(google::protobuf::Message* message); findAllPossibleProtoFields(const google::protobuf::Descriptor* descriptor);
extern ConfigProto parseConfigBytes(const std::string_view& bytes); extern std::map<std::string, const google::protobuf::FieldDescriptor*>
findAllProtoFields(const google::protobuf::Message& message);
template <class T>
static inline const T parseProtoBytes(const std::string_view& bytes)
{
T proto;
if (!proto.ParseFromArray(bytes.begin(), bytes.size()))
error("invalid internal proto data");
return proto;
}
extern const std::map<std::string, const ConfigProto*> formats; extern const std::map<std::string, const ConfigProto*> formats;

3
lib/core/globals.h
View File

@@ -23,6 +23,9 @@
#define mkdir(A, B) _mkdir(A) #define mkdir(A, B) _mkdir(A)
#endif #endif
#define STRINGIFY(a) XSTRINGIFY(a)
#define XSTRINGIFY(a) #a
template <class T> template <class T>
static inline std::vector<T> vector_of(T item) static inline std::vector<T> vector_of(T item)
{ {

8
scripts/build.py
View File

@@ -5,13 +5,14 @@ encoders = {}
@Rule @Rule
def protoencode_single(self, name, srcs: Targets, proto, symbol): def protoencode_single(self, name, srcs: Targets, proto, include, symbol):
if proto not in encoders: if proto not in encoders:
r = cxxprogram( r = cxxprogram(
name="protoencode_" + proto, name="protoencode_" + proto,
srcs=["scripts/protoencode.cc"], srcs=["scripts/protoencode.cc"],
cflags=["-DPROTO=" + proto], cflags=["-DPROTO=" + proto, "-DINCLUDE="+include],
deps=[ deps=[
"lib/core",
"lib/config+proto_lib", "lib/config+proto_lib",
"lib/fluxsource+proto_lib", "lib/fluxsource+proto_lib",
"lib/fluxsink+proto_lib", "lib/fluxsink+proto_lib",
@@ -41,12 +42,13 @@ def protoencode_single(self, name, srcs: Targets, proto, symbol):
@Rule @Rule
def protoencode(self, name, proto, srcs: TargetsMap, symbol): def protoencode(self, name, proto, include,srcs: TargetsMap, symbol):
encoded = [ encoded = [
protoencode_single( protoencode_single(
name=f"{k}_cc", name=f"{k}_cc",
srcs=[v], srcs=[v],
proto=proto, proto=proto,
include=include,
symbol=f"{symbol}_{k}_pb", symbol=f"{symbol}_{k}_pb",
) )
for k, v in srcs.items() for k, v in srcs.items()

14
scripts/protoencode.cc
View File

@@ -3,12 +3,13 @@
#include <google/protobuf/io/zero_copy_stream_impl.h> #include <google/protobuf/io/zero_copy_stream_impl.h>
#include <fstream> #include <fstream>
#include "fmt/format.h" #include "fmt/format.h"
#include "lib/core/globals.h"
#include "tests/testproto.pb.h" #include "tests/testproto.pb.h"
#include "lib/config/config.pb.h" #include "lib/config/config.pb.h"
#include <sstream> #include <sstream>
#include <locale> #include <locale>
#define STRINGIFY(s) #s const std::string protoname = STRINGIFY(PROTO);
static uint32_t readu8(std::string::iterator& it, std::string::iterator end) static uint32_t readu8(std::string::iterator& it, std::string::iterator end)
{ {
@@ -125,6 +126,7 @@ int main(int argc, const char* argv[])
output << "#include \"lib/core/globals.h\"\n" output << "#include \"lib/core/globals.h\"\n"
<< "#include \"lib/config/proto.h\"\n" << "#include \"lib/config/proto.h\"\n"
<< "#include \"" STRINGIFY(INCLUDE) "\"\n"
<< "#include <string_view>\n" << "#include <string_view>\n"
<< "static const uint8_t " << name << "_rawData[] = {"; << "static const uint8_t " << name << "_rawData[] = {";
@@ -143,11 +145,11 @@ int main(int argc, const char* argv[])
output << "\n};\n"; output << "\n};\n";
output << "extern const std::string_view " << name << "_data;\n"; output << "extern const std::string_view " << name << "_data;\n";
output << "const std::string_view " << name output << "const std::string_view " << name
<< "_data = std::string_view((const char*)" << name << "_rawData, " << data.size() << "_data = std::string_view((const char*)" << name << "_rawData, "
<< ");\n"; << data.size() << ");\n";
output << "extern const ConfigProto " << name << ";\n"; output << "extern const " << protoname << " " << name << ";\n";
output << "const ConfigProto " << name << " = parseConfigBytes(" output << "const " << protoname << " " << name << " = parseProtoBytes<"
<< argv[3] << "_data);\n"; << protoname << ">(" << argv[3] << "_data);\n";
return 0; return 0;
} }

34
tests/build.py
View File

@@ -39,44 +39,38 @@ tests = [
"vfs", "vfs",
] ]
protoencode_single(
name="testproto_cc",
srcs=["./testproto.textpb"],
proto="TestProto",
include="tests/testproto.pb.h",
symbol="testproto_pb",
)
export( export(
name="tests", name="tests",
deps=[ deps=[
test( test(
name="proto_test", name=f"{n}_test",
command=cxxprogram( command=cxxprogram(
name="proto_test_exe", name=f"{n}_test_exe",
srcs=[ srcs=[
"./proto.cc", f"./{n}.cc",
protoencode_single( ".+testproto_cc",
name="testproto_cc",
srcs=["./testproto.textpb"],
proto="TestProto",
symbol="testproto_pb",
),
], ],
deps=[ deps=[
"lib/external+fl2_proto_lib",
"+fmt_lib", "+fmt_lib",
"+protobuf_lib", "+protobuf_lib",
"+protocol", "+protocol",
"+z_lib",
".+test_proto_lib", ".+test_proto_lib",
"dep/adflib",
"dep/agg",
"dep/fatfs",
"dep/hfsutils",
"dep/libusbp",
"dep/snowhouse", "dep/snowhouse",
"dep/stb",
"lib/config", "lib/config",
"lib/core", "lib/core",
"lib/data",
"lib/fluxsource+proto_lib", "lib/fluxsource+proto_lib",
"src/formats",
], ],
), ),
), )
for n in ["proto"]
] ]
+ [ + [
test( test(

89
tests/proto.cc
View File

@@ -28,8 +28,9 @@ static void test_setting(void)
setProtoByString(&config, "d", "5.5"); setProtoByString(&config, "d", "5.5");
setProtoByString(&config, "f", "6.7"); setProtoByString(&config, "f", "6.7");
setProtoByString(&config, "m.s", "string"); setProtoByString(&config, "m.s", "string");
setProtoByString(&config, "r.s", "val1"); setProtoByString(&config, "r[0].s", "val1");
setProtoByString(&config, "r.s", "val2"); setProtoByString(&config, "r[0].s", "val2");
setProtoByString(&config, "r[1].s", "val3");
setProtoByString(&config, "firstoption.s", "1"); setProtoByString(&config, "firstoption.s", "1");
setProtoByString(&config, "secondoption.s", "2"); setProtoByString(&config, "secondoption.s", "2");
setProtoByString(&config, "range", "1-3x2"); setProtoByString(&config, "range", "1-3x2");
@@ -49,6 +50,9 @@ static void test_setting(void)
r { r {
s: "val2" s: "val2"
} }
r {
s: "val3"
}
secondoption { secondoption {
s: "2" s: "2"
} }
@@ -76,6 +80,9 @@ static void test_getting(void)
r { r {
s: "val2" s: "val2"
} }
r {
s: "val3"
}
secondoption { secondoption {
s: "2" s: "2"
} }
@@ -97,7 +104,8 @@ static void test_getting(void)
AssertThat(getProtoByString(&tp, "d"), Equals("5.5")); AssertThat(getProtoByString(&tp, "d"), Equals("5.5"));
AssertThat(getProtoByString(&tp, "f"), Equals("6.7")); AssertThat(getProtoByString(&tp, "f"), Equals("6.7"));
AssertThat(getProtoByString(&tp, "m.s"), Equals("string")); AssertThat(getProtoByString(&tp, "m.s"), Equals("string"));
AssertThat(getProtoByString(&tp, "r.s"), Equals("val2")); AssertThat(getProtoByString(&tp, "r[0].s"), Equals("val2"));
AssertThat(getProtoByString(&tp, "r[1].s"), Equals("val3"));
AssertThrows( AssertThrows(
ProtoPathNotFoundException, getProtoByString(&tp, "firstoption.s")); ProtoPathNotFoundException, getProtoByString(&tp, "firstoption.s"));
AssertThat(getProtoByString(&tp, "secondoption.s"), Equals("2")); AssertThat(getProtoByString(&tp, "secondoption.s"), Equals("2"));
@@ -206,8 +214,27 @@ static void test_range(void)
static void test_fields(void) static void test_fields(void)
{ {
TestProto proto; TestProto proto;
auto fields = findAllProtoFields(&proto); auto fields = findAllPossibleProtoFields(proto.GetDescriptor());
AssertThat(fields.size(), Equals(18)); std::vector<std::string> fieldNames;
for (const auto& e : fields)
fieldNames.push_back(e.first);
AssertThat(fieldNames,
Equals(std::vector<std::string>{"d",
"f",
"firstoption",
"firstoption.s",
"i32",
"i64",
"m",
"m.s",
"r[]",
"r[].s",
"range",
"secondoption",
"secondoption.s",
"u32",
"u64"}));
} }
static void test_options(void) static void test_options(void)
@@ -220,6 +247,57 @@ static void test_options(void)
AssertThat(s, Equals("i64")); AssertThat(s, Equals("i64"));
} }
static void test_findallfields(void)
{
std::string s = R"M(
i64: -1
i32: -2
u64: 3
u32: 4
d: 5.5
f: 6.7
m {
s: "string"
}
r {
s: "val2"
}
r {
s: "val3"
}
secondoption {
s: "2"
}
range {
start: 1
step: 2
end: 3
}
)M";
TestProto proto;
if (!google::protobuf::TextFormat::MergeFromString(cleanup(s), &proto))
error("couldn't load test proto");
auto fields = findAllProtoFields(proto);
std::vector<std::string> fieldNames;
for (const auto& e : fields)
fieldNames.push_back(e.first);
AssertThat(fieldNames,
Equals(std::vector<std::string>{"d",
"f",
"i32",
"i64",
"m.s",
"r[0].s",
"r[1].s",
"range",
"secondoption.s",
"u32",
"u64"}));
}
int main(int argc, const char* argv[]) int main(int argc, const char* argv[])
{ {
try try
@@ -231,6 +309,7 @@ int main(int argc, const char* argv[])
test_range(); test_range();
test_fields(); test_fields();
test_options(); test_options();
test_findallfields();
} }
catch (const ErrorException& e) catch (const ErrorException& e)
{ {

38
tests/testproto.proto
View File

@@ -2,25 +2,27 @@ syntax = "proto2";
import "lib/config/common.proto"; import "lib/config/common.proto";
message TestProto { message TestProto
message SubMessageProto { {
optional string s = 1; message SubMessageProto
} {
optional string s = 1;
}
optional int64 i64 = 1 [(help)="i64"]; optional int64 i64 = 1 [(help) = "i64"];
optional int32 i32 = 2; optional int32 i32 = 2;
optional uint64 u64 = 3; optional uint64 u64 = 3;
optional uint32 u32 = 4; optional uint32 u32 = 4;
optional double d = 5; optional double d = 5;
optional double f = 11; optional double f = 11;
optional SubMessageProto m = 6; optional SubMessageProto m = 6;
repeated SubMessageProto r = 7; repeated SubMessageProto r = 7;
oneof alt { oneof alt
SubMessageProto firstoption = 8; {
SubMessageProto secondoption = 9; SubMessageProto firstoption = 8;
} SubMessageProto secondoption = 9;
}
optional RangeProto range = 10; optional RangeProto range = 10;
} }