mirror of
				https://github.com/ytdl-org/youtube-dl.git
				synced 2025-10-29 09:26:20 -07:00 
			
		
		
		
	[test] Skip not _WORKING IE in subtitle tests; use unittest.skipTest throughout
This commit is contained in:
		| @@ -88,7 +88,6 @@ class TestDownload(unittest.TestCase): | ||||
|  | ||||
| # Dynamically generate tests | ||||
|  | ||||
|  | ||||
| def generator(test_case, tname): | ||||
|  | ||||
|     def test_template(self): | ||||
| @@ -100,9 +99,10 @@ def generator(test_case, tname): | ||||
|  | ||||
|         def print_skipping(reason): | ||||
|             print('Skipping %s: %s' % (test_case['name'], reason)) | ||||
|             self.skipTest(reason) | ||||
|  | ||||
|         if not ie.working(): | ||||
|             print_skipping('IE marked as not _WORKING') | ||||
|             return | ||||
|  | ||||
|         for tc in test_cases: | ||||
|             info_dict = tc.get('info_dict', {}) | ||||
| @@ -111,11 +111,10 @@ def generator(test_case, tname): | ||||
|  | ||||
|         if 'skip' in test_case: | ||||
|             print_skipping(test_case['skip']) | ||||
|             return | ||||
|  | ||||
|         for other_ie in other_ies: | ||||
|             if not other_ie.working(): | ||||
|                 print_skipping('test depends on %sIE, marked as not WORKING' % other_ie.ie_key()) | ||||
|                 return | ||||
|  | ||||
|         params = get_params(test_case.get('params', {})) | ||||
|         params['outtmpl'] = tname + '_' + params['outtmpl'] | ||||
|   | ||||
| @@ -38,6 +38,9 @@ class BaseTestSubtitles(unittest.TestCase): | ||||
|         self.DL = FakeYDL() | ||||
|         self.ie = self.IE() | ||||
|         self.DL.add_info_extractor(self.ie) | ||||
|         if not self.IE.working(): | ||||
|             print('Skipping: %s marked as not _WORKING' % self.IE.ie_key()) | ||||
|             self.skipTest('IE marked as not _WORKING') | ||||
|  | ||||
|     def getInfoDict(self): | ||||
|         info_dict = self.DL.extract_info(self.url, download=False) | ||||
|   | ||||
		Reference in New Issue
	
	Block a user